Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: article meta & featured collection size as per design #286

Merged
merged 4 commits into from
Oct 26, 2023

Conversation

alfonsobries
Copy link
Contributor

@alfonsobries alfonsobries commented Oct 25, 2023

Summary

Closes https://app.clickup.com/t/862kh47a3 and fixed this https://app.clickup.com/t/862kh47kw as a side effect

Checklist

  • I checked my UI changes against the design and there are no notable differences
  • I checked my UI changes for any responsiveness issues
  • I checked my (code) changes for obvious issues, debug statements and commented code
  • I opened a corresponding card on Clickup for any remaining TODOs in my code
  • I added a short description on how to test this PR (if necessary)
  • I added a storybook entry for the component that was added (if necessary)
  • Documentation (if necessary)
  • Tests (if necessary)
  • Ready to be merged

@crnkovic crnkovic self-assigned this Oct 26, 2023
Copy link
Contributor

@crnkovic crnkovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oleg specified that on >= 768px, slider should be inline with the title, but that would just cramp too much and at most 3 collections would fit in a slide view, and this approach makes more sense to not be cramped.

Screenshot 2023-10-26 at 11 42 49

@ItsANameToo ItsANameToo merged commit bc09dab into feat/articles Oct 26, 2023
12 checks passed
@ItsANameToo ItsANameToo deleted the fix/featured-collection-design-issue branch October 26, 2023 09:54
@ItsANameToo ItsANameToo added this to the 0.10.0 milestone Oct 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants