Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: dark mode for wallet components #289

Merged
merged 17 commits into from
Oct 26, 2023

Conversation

patricio0312rev
Copy link
Contributor

[general] dark mode: [wallet] token slider dark mode

Summary

  • Dark mode has been enabled for multiple token/wallet slider components:
    • Token transactions slider
    • Transaction details slider
    • Token market data slider
    • Send token slider
    • Execution token slider
    • Result token slider
  • Tests for these implementations have been updated.

Steps to reproduce

  1. Run the app in local or testing_e2e mode.
  2. Go to Settings and turn on the Dark mode slider.
  3. Go to /wallet page.
  4. Navigate in the page and see the magic ✨
Screen.Recording.2023-10-25.at.18.16.57.mov

Checklist

  • I checked my UI changes against the design and there are no notable differences
  • I checked my UI changes for any responsiveness issues
  • I checked my (code) changes for obvious issues, debug statements and commented code
  • I opened a corresponding card on Clickup for any remaining TODOs in my code
  • I added a short description on how to test this PR (if necessary)
  • I added a storybook entry for the component that was added (if necessary)
  • Documentation (if necessary)
  • Tests (if necessary)
  • Ready to be merged

@patricio0312rev patricio0312rev marked this pull request as ready for review October 25, 2023 23:18
@crnkovic
Copy link
Contributor

failing test @patricio0312rev

@ItsANameToo ItsANameToo marked this pull request as draft October 26, 2023 10:00
@ItsANameToo ItsANameToo added this to the 0.9.0 milestone Oct 26, 2023
@patricio0312rev patricio0312rev marked this pull request as ready for review October 26, 2023 16:10
@ItsANameToo
Copy link
Contributor

more failing tests @patricio0312rev

@ItsANameToo ItsANameToo marked this pull request as draft October 26, 2023 16:21
@patricio0312rev patricio0312rev marked this pull request as ready for review October 26, 2023 16:23
@ItsANameToo ItsANameToo merged commit 3c12f77 into develop Oct 26, 2023
16 checks passed
@ItsANameToo ItsANameToo deleted the feat/dark-mode-for-wallet-components branch October 26, 2023 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants