feat: add articles audio player #305
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # .env.example # composer.lock
# Conflicts: # app/Models/Article.php # tests/App/Http/Controllers/ArticleControllerTest.php
crnkovic
reviewed
Oct 27, 2023
ItsANameToo
requested changes
Oct 31, 2023
resources/icons/audio-play.svg
Outdated
| @@ -0,0 +1 @@ | |||
| <svg width="20" height="21" viewBox="0 0 20 21" fill="none" xmlns="http://www.w3.org/2000/svg"><path d="M12.852 6.67c2.724 1.676 4.085 2.514 4.341 3.68.087.398.087.809 0 1.206-.256 1.166-1.617 2.004-4.34 3.68C9.89 17.06 8.41 17.97 7.21 17.62a2.812 2.812 0 0 1-1.095-.611c-.928-.838-.928-2.577-.928-6.055 0-3.478 0-5.217.928-6.054a2.813 2.813 0 0 1 1.095-.612c1.2-.351 2.68.56 5.642 2.383Z" fill="currentColor"/></svg> | |||
There was a problem hiding this comment.
best to remove width and height and only keep the viewBox so it's possible to use different sizes for the image. Same applies to the other one
There was a problem hiding this comment.
- removed width and height
- set fixed height for the spinner container, so it will have the same height with wave.
… feat/articles-audio-player
ItsANameToo
approved these changes
Oct 31, 2023
goga-m
reviewed
Oct 31, 2023
patricio0312rev
approved these changes
Oct 31, 2023
goga-m
approved these changes
Oct 31, 2023
… feat/articles-audio-player
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Closes: https://app.clickup.com/t/8678v0juv
This PR implements two audio players:
For testing:
ArticleSeederaudio_file_urlTry both and pick your side
Checklist