refactor: use scaled endpoint for nft images #308
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,36 @@ | ||
| <?php | ||
|
|
||
| declare(strict_types=1); | ||
|
|
||
| use Illuminate\Database\Migrations\Migration; | ||
| use Illuminate\Support\Facades\DB; | ||
|
|
||
| return new class() extends Migration | ||
| { | ||
| /** | ||
| * Run the migrations. | ||
| */ | ||
| public function up(): void | ||
| { | ||
| DB::table('nfts') | ||
| ->whereRaw("extra_attributes->'images'->>'thumb' LIKE '%thumbnailv2%'") | ||
| ->orWhereRaw("extra_attributes->'images'->>'small' LIKE '%thumbnailv2%'") | ||
| ->orWhereRaw("extra_attributes->'images'->>'large' LIKE '%thumbnailv2%'")->get()->each(function ($nft) { | ||
| $extraAttributes = json_decode($nft->extra_attributes); | ||
|
There was a problem hiding this comment. for this I meant an actual query that updates the values and doesn't rely on eloquent models. You rewrote it now, but it will contain the same amount of models as before as they basically all use that thumbnail |
||
|
|
||
| $extraAttributes->images->thumb = $this->replaceThumbnailsWithScaled($extraAttributes->images->thumb); | ||
| $extraAttributes->images->small = $this->replaceThumbnailsWithScaled($extraAttributes->images->small); | ||
| $extraAttributes->images->large = $this->replaceThumbnailsWithScaled($extraAttributes->images->large); | ||
|
|
||
| DB::table('nfts') | ||
| ->where('id', $nft->id) | ||
| ->update(['extra_attributes' => json_encode($extraAttributes)]); | ||
|
|
||
| }); | ||
| } | ||
|
|
||
| public function replaceThumbnailsWithScaled(string $url): string | ||
| { | ||
| return preg_replace('/thumbnailv2/', 'scaled', $url); | ||
| } | ||
| }; | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we update existing image urls by replacing it as such as well? if so, it would be good to add a migration that would update the existing NFTs so they are all using the new format