Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: coverage for unknown network prop in marketplaces component #323

Merged
merged 1 commit into from
Oct 31, 2023

Conversation

patricio0312rev
Copy link
Contributor

[test] flaky marketplaces test

Summary

  • Coverage for the default case in getNetworkName has been added.
  • Now, the buttons will get # if the network is invalid. This will prevent the URLs from having missing props.
  • A unit test has been added for these changes.
image

Checklist

  • I checked my UI changes against the design and there are no notable differences
  • I checked my UI changes for any responsiveness issues
  • I checked my (code) changes for obvious issues, debug statements and commented code
  • I opened a corresponding card on Clickup for any remaining TODOs in my code
  • I added a short description on how to test this PR (if necessary)
  • I added a storybook entry for the component that was added (if necessary)
  • Documentation (if necessary)
  • Tests (if necessary)
  • Ready to be merged

@patricio0312rev patricio0312rev marked this pull request as ready for review October 31, 2023 12:19
@goga-m goga-m merged commit 807204a into develop Oct 31, 2023
14 checks passed
@goga-m goga-m deleted the fix/flaky-marketplaces-test branch October 31, 2023 12:35
@ItsANameToo ItsANameToo modified the milestones: 0.11.0, 0.10.0 Nov 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants