feat: persist gallery draft #326
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o feat/persist-gallery-drafts
…o feat/persist-gallery-drafts
shahin-hq
commented
Oct 31, 2023
| // eslint-disable-next-line promise/prefer-await-to-then | ||
| void blob.arrayBuffer().then((buf) => { | ||
| setDraftCover(buf, blob.type); | ||
| }); |
There was a problem hiding this comment.
I didn't want to make this function async that is why used then
9 tasks
…o feat/persist-gallery-drafts
# Conflicts: # resources/js/Hooks/useGalleryDrafts.ts
# Conflicts: # resources/js/Components/Sidebar/SidebarItem.tsx # resources/js/I18n/Locales/en.json # resources/js/Pages/Settings/Layout.tsx
# Conflicts: # resources/js/Components/Sidebar/SidebarItem.tsx # resources/js/I18n/Locales/en.json
…eat/save-gallery-drafts
# Conflicts: # resources/js/I18n/Locales/en.json
Base automatically changed from
feat/persist-gallery-drafts
to
feat/gallery-drafts
November 2, 2023 15:13
# Conflicts: # resources/js/Pages/Galleries/hooks/useGalleryDrafts.test.ts # resources/js/Pages/Galleries/hooks/useGalleryDrafts.ts
9 tasks
patricio0312rev
approved these changes
Nov 2, 2023
alfonsobries
approved these changes
Nov 2, 2023
alfonsobries
force-pushed
the
feat/save-gallery-drafts
branch
from
09ca991 to
cd569ac
Compare
ItsANameToo
approved these changes
Nov 3, 2023
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Closes: https://app.clickup.com/t/862kh23eg
Checklist