Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove redundant tooltip in activity refresh button #328

Merged
merged 3 commits into from
Oct 31, 2023

Conversation

goga-m
Copy link
Contributor

@goga-m goga-m commented Oct 31, 2023

Summary

No task but, see discussion in https://helloardent.slack.com/archives/C04P3DGJJ1W/p1698768310805259

  • Preserves the activity table when clicking "refresh" instead of replacing it with "Loading" message block.
  • Removes the redundant tooltip on collection activity refresh button (See attached preview)

image (11)

Checklist

  • I checked my UI changes against the design and there are no notable differences
  • I checked my UI changes for any responsiveness issues
  • I checked my (code) changes for obvious issues, debug statements and commented code
  • I opened a corresponding card on Clickup for any remaining TODOs in my code
  • I added a short description on how to test this PR (if necessary)
  • I added a storybook entry for the component that was added (if necessary)
  • Documentation (if necessary)
  • Tests (if necessary)
  • Ready to be merged

@goga-m goga-m changed the title fix: remove redundant activity refresh tooltip fix: remove redundant tooltip in activity refresh button Oct 31, 2023
@ItsANameToo ItsANameToo merged commit 30edb30 into rc-0.9.0 Oct 31, 2023
12 checks passed
@ItsANameToo ItsANameToo deleted the fix/remove-redundant-refresh-tooltip branch October 31, 2023 16:46
@ItsANameToo ItsANameToo added this to the 0.9.0 milestone Oct 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants