Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: set height for navbar menu items #330

Merged
merged 2 commits into from
Nov 1, 2023
Merged

Conversation

patricio0312rev
Copy link
Contributor

[navbar] white space between navbar line and selected/hover lines

Summary

  • The height for the navbar menu items has been set as 72px, just as in our Figma file.
  • As an addition, the class names for dark mode on the galleries page have been added.

## Steps to reproduce

  1. Run the app in local or test_e2e mode.
  2. Go to /galleries page and see the magic ✨

Checklist

  • I checked my UI changes against the design and there are no notable differences
  • I checked my UI changes for any responsiveness issues
  • I checked my (code) changes for obvious issues, debug statements and commented code
  • I opened a corresponding card on Clickup for any remaining TODOs in my code
  • I added a short description on how to test this PR (if necessary)
  • I added a storybook entry for the component that was added (if necessary)
  • Documentation (if necessary)
  • Tests (if necessary)
  • Ready to be merged

@patricio0312rev patricio0312rev marked this pull request as ready for review October 31, 2023 18:42
@goga-m goga-m merged commit 9d1b9fc into rc-0.9.0 Nov 1, 2023
14 checks passed
@goga-m goga-m deleted the fix/whitespace-in-navbar branch November 1, 2023 09:43
@ItsANameToo ItsANameToo added this to the 0.9.0 milestone Nov 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants