Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: use async call in authenticatedAction #331

Merged
merged 1 commit into from
Nov 1, 2023

Conversation

alfonsobries
Copy link
Contributor

Summary

This pr added the authenticatedAction but in order to work (show the connect modal if session is lost) the axios call need to be async

To test login with your wallet, open the collections page, clear browser data, press refresh, you should see the connect modal.

Checklist

  • I checked my UI changes against the design and there are no notable differences
  • I checked my UI changes for any responsiveness issues
  • I checked my (code) changes for obvious issues, debug statements and commented code
  • I opened a corresponding card on Clickup for any remaining TODOs in my code
  • I added a short description on how to test this PR (if necessary)
  • I added a storybook entry for the component that was added (if necessary)
  • Documentation (if necessary)
  • Tests (if necessary)
  • Ready to be merged

@ItsANameToo ItsANameToo added this to the 0.9.0 milestone Nov 1, 2023
@ItsANameToo ItsANameToo merged commit e601a7f into rc-0.9.0 Nov 1, 2023
12 checks passed
@ItsANameToo ItsANameToo deleted the chore/use-async-call-in-auth-action branch November 1, 2023 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants