Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: make Platforms enum singular #335

Merged
merged 3 commits into from
Nov 1, 2023
Merged

Conversation

crnkovic
Copy link
Contributor

@crnkovic crnkovic commented Nov 1, 2023

Summary

https://app.clickup.com/t/862khr43x

This PR renames the Platforms enum to Platform and renames its platforms method to all, so there's no weird stuff like Platforms::platforms() :trollface:

Also, this enum and TokenGuid enum are never used in the UI so there's no reason for them have TS version generated.

Checklist

  • I checked my UI changes against the design and there are no notable differences
  • I checked my UI changes for any responsiveness issues
  • I checked my (code) changes for obvious issues, debug statements and commented code
  • I opened a corresponding card on Clickup for any remaining TODOs in my code
  • I added a short description on how to test this PR (if necessary)
  • I added a storybook entry for the component that was added (if necessary)
  • Documentation (if necessary)
  • Tests (if necessary)
  • Ready to be merged

@crnkovic crnkovic marked this pull request as ready for review November 1, 2023 14:37
@goga-m goga-m merged commit 9126012 into develop Nov 1, 2023
16 checks passed
@goga-m goga-m deleted the refactor/singular-enum branch November 1, 2023 15:31
@ItsANameToo ItsANameToo added this to the 0.11.0 milestone Nov 1, 2023
@goga-m goga-m modified the milestones: 0.11.0, 0.10.0 Nov 1, 2023
@ItsANameToo ItsANameToo modified the milestones: 0.11.0, 0.10.0 Nov 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants