Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: maintain selected value on listbox #340

Merged
merged 3 commits into from
Nov 3, 2023
Merged

fix: maintain selected value on listbox #340

merged 3 commits into from
Nov 3, 2023

Conversation

alfonsobries
Copy link
Contributor

Summary

Closes https://app.clickup.com/t/862khrc1q

Checklist

  • I checked my UI changes against the design and there are no notable differences
  • I checked my UI changes for any responsiveness issues
  • I checked my (code) changes for obvious issues, debug statements and commented code
  • I opened a corresponding card on Clickup for any remaining TODOs in my code
  • I added a short description on how to test this PR (if necessary)
  • I added a storybook entry for the component that was added (if necessary)
  • Documentation (if necessary)
  • Tests (if necessary)
  • Ready to be merged

@github-actions github-actions bot added the bugfix label Nov 1, 2023
@ItsANameToo ItsANameToo added this to the 0.11.0 milestone Nov 2, 2023
@goga-m
Copy link
Contributor

goga-m commented Nov 2, 2023

@alfonsobries some minor conflicts after merging #337

@goga-m goga-m marked this pull request as draft November 2, 2023 12:14
@alfonsobries alfonsobries marked this pull request as ready for review November 2, 2023 17:29
@alfonsobries
Copy link
Contributor Author

@goga-m can be reviewed again

@goga-m goga-m merged commit 2e36666 into develop Nov 3, 2023
14 checks passed
@goga-m goga-m deleted the fix/listbox-selected-value branch November 3, 2023 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ItsANameToo ItsANameToo ItsANameToo approved these changes

@goga-m goga-m goga-m approved these changes

@samharperpittam samharperpittam Awaiting requested review from samharperpittam samharperpittam is a code owner

@boldninja boldninja Awaiting requested review from boldninja boldninja is a code owner

Assignees
No one assigned
Labels
bugfix
Projects
None yet
Milestone
0.11.0
Development

Successfully merging this pull request may close these issues.
3 participants
@alfonsobries @goga-m @ItsANameToo