Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: dark mode for more soon article skeleton card #348

Merged
merged 2 commits into from
Nov 3, 2023

Conversation

patricio0312rev
Copy link
Contributor

[articles] add dark mode to coming soon placeholders

Summary

  • Dark mode has been added to "More soon" skeleton cards for articles.

Steps to reproduce

  1. Run the app in local or testing_e2e mode.
  2. Remove all the entries in your articles table in your local DB.
  3. Go to /articles page.
  4. Turn on dark mode in the navbar and see the magic ✨

Screenshot

image

Note: Wanted to activate animation for skeleton components, but it seems odd and it was configured to be off, too. Let me know if it is necessary to turn it on.

Checklist

  • I checked my UI changes against the design and there are no notable differences
  • I checked my UI changes for any responsiveness issues
  • I checked my (code) changes for obvious issues, debug statements and commented code
  • I opened a corresponding card on Clickup for any remaining TODOs in my code
  • I added a short description on how to test this PR (if necessary)
  • I added a storybook entry for the component that was added (if necessary)
  • Documentation (if necessary)
  • Tests (if necessary)
  • Ready to be merged

@patricio0312rev patricio0312rev marked this pull request as ready for review November 2, 2023 16:41
@patricio0312rev patricio0312rev changed the base branch from develop to rc-0.10.0 November 2, 2023 16:41
@ItsANameToo ItsANameToo added this to the 0.10.0 milestone Nov 3, 2023
Copy link
Contributor

@ItsANameToo ItsANameToo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

regarding the animation, they are off for a reason. These placeholders aren't loading states, so if you would enable the animation it would give the impression the articles are loading while that's not the case @patricio0312rev

@ItsANameToo ItsANameToo changed the title feat: dark mode for more soon article skeleton card refactor: dark mode for more soon article skeleton card Nov 3, 2023
@ItsANameToo ItsANameToo merged commit 1fa03b5 into rc-0.10.0 Nov 3, 2023
12 checks passed
@ItsANameToo ItsANameToo deleted the feat/dark-mode-for-article-skeleton-cards branch November 3, 2023 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants