fix: external link url disappears before the closing transition ends #366
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
https://app.clickup.com/t/862kj4b5v
Previously, the shown/hidden state depended on the URL being set or not, so we first had to clear the URL to get the modal to close, but since the modal has a transition, this created this visual bug. Now, the modal is managed by its own
open
state, so we can leave the URL in the state until the next external link modal is opened, at which point the URL is just replaced with the new one. This way, the URL will be visible even during the modal closing transition.Screen.Recording.2023-11-06.at.10.43.27.mov
Checklist