Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: external link url disappears before the closing transition ends #366

Merged
merged 1 commit into from
Nov 6, 2023

Conversation

crnkovic
Copy link
Contributor

@crnkovic crnkovic commented Nov 6, 2023

Summary

https://app.clickup.com/t/862kj4b5v

Previously, the shown/hidden state depended on the URL being set or not, so we first had to clear the URL to get the modal to close, but since the modal has a transition, this created this visual bug. Now, the modal is managed by its own open state, so we can leave the URL in the state until the next external link modal is opened, at which point the URL is just replaced with the new one. This way, the URL will be visible even during the modal closing transition.

Screen.Recording.2023-11-06.at.10.43.27.mov

Checklist

  • I checked my UI changes against the design and there are no notable differences
  • I checked my UI changes for any responsiveness issues
  • I checked my (code) changes for obvious issues, debug statements and commented code
  • I opened a corresponding card on Clickup for any remaining TODOs in my code
  • I added a short description on how to test this PR (if necessary)
  • I added a storybook entry for the component that was added (if necessary)
  • Documentation (if necessary)
  • Tests (if necessary)
  • Ready to be merged

@github-actions github-actions bot added the bugfix label Nov 6, 2023
@crnkovic crnkovic marked this pull request as ready for review November 6, 2023 09:46
@crnkovic crnkovic changed the title fix: external link url disappears fix: external link url disappears before the closing transition ends Nov 6, 2023
@ItsANameToo ItsANameToo added this to the 0.11.0 milestone Nov 6, 2023
@ItsANameToo ItsANameToo merged commit 2a8c343 into develop Nov 6, 2023
14 checks passed
@ItsANameToo ItsANameToo deleted the fix/external-link branch November 6, 2023 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants