refactor: create gallery NFTs #370
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to refactor/create-gallery-nfts
…to refactor/create-gallery-nfts
…to refactor/create-gallery-nfts
shahin-hq
commented
Nov 6, 2023
| @@ -204,10 +198,6 @@ export const useGalleryNtfs = ({ | |||
| }; | |||
|
|
|||
| const searchNfts = async (query?: string): Promise<void> => { | |||
| if (!isTruthy(pageMeta.first_page_url)) { | |||
| throw new Error("[searchNfts] First page url is not defined."); | |||
There was a problem hiding this comment.
first_page_url is always there, so we can remove this check.
shahin-hq
commented
Nov 6, 2023
There was a problem hiding this comment.
Fixing broken tests, nothing new.
crnkovic
suggested changes
Nov 6, 2023
|
some conflicts in the meantime @shahin-hq |
# Conflicts: # app/Http/Controllers/MyGalleryController.php # tests/App/Http/Controllers/MyGalleryControllerTest.php
alfonsobries
approved these changes
Nov 8, 2023
ItsANameToo
approved these changes
Nov 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
https://app.clickup.com/t/86793qcn4
This PR refactors the
useGalleryNftshook to be responsible for fetching and searching NFTs. In short, I removed logic that fetches NFTs in backend and passes to the frontend components because the NFT slider doesn't really use the preloaded data. Removing backend fetching is a good idea because of the reasons below:react-queryto cache data - we don't have to fetch NFTs every time user opens the slider, we could cache and reuseChecklist