Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: properly count galleries for sidebar in "my galleries" #372

Merged
merged 4 commits into from
Nov 7, 2023
Merged

refactor: properly count galleries for sidebar in "my galleries" #372

merged 4 commits into from
Nov 7, 2023

Conversation

crnkovic
Copy link
Contributor

@crnkovic crnkovic commented Nov 6, 2023 •
edited by goga-m
Loading

Summary

https://app.clickup.com/t/862kj6pht

Since fetching the drafts is an async function, I opted for showing a little spinner until the data loads, think it looks nice.

Screen.Recording.2023-11-06.at.16.23.08.mov

Checklist

  • I checked my UI changes against the design and there are no notable differences
  • I checked my UI changes for any responsiveness issues
  • I checked my (code) changes for obvious issues, debug statements and commented code
  • I opened a corresponding card on Clickup for any remaining TODOs in my code
  • I added a short description on how to test this PR (if necessary)
  • I added a storybook entry for the component that was added (if necessary)
  • Documentation (if necessary)
  • Tests (if necessary)
  • Ready to be merged

@crnkovic crnkovic marked this pull request as ready for review November 6, 2023 15:36
@ItsANameToo ItsANameToo added this to the 0.11.0 milestone Nov 6, 2023
patricio0312rev
patricio0312rev approved these changes Nov 7, 2023
View reviewed changes
Copy link
Contributor

@patricio0312rev patricio0312rev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lit 🔥

@goga-m goga-m merged commit 6f83012 into feat/gallery-drafts Nov 7, 2023
16 checks passed
@goga-m goga-m deleted the refactor/gallery-counts-sidebar branch November 7, 2023 10:27
@goga-m goga-m mentioned this pull request Nov 15, 2023
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patricio0312rev patricio0312rev patricio0312rev approved these changes

@goga-m goga-m goga-m approved these changes

@samharperpittam samharperpittam Awaiting requested review from samharperpittam

@boldninja boldninja Awaiting requested review from boldninja

Assignees
No one assigned
Labels
refactor
Projects
None yet
Milestone
0.11.0
Development

Successfully merging this pull request may close these issues.
4 participants
@crnkovic @goga-m @patricio0312rev @ItsANameToo