-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: prevent the user from selecting more than 16 nfts #373
Merged
ItsANameToo
merged 16 commits into
develop
from
feat/prevent-selecting-more-than-16-nfts
Nov 9, 2023
Merged
refactor: prevent the user from selecting more than 16 nfts #373
ItsANameToo
merged 16 commits into
develop
from
feat/prevent-selecting-more-than-16-nfts
Nov 9, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patricio0312rev
requested review from
samharperpittam and
boldninja
as code owners
November 6, 2023 17:16
ItsANameToo
changed the title
feat: prevent the user from selecting more than 16 nfts
refactor: prevent the user from selecting more than 16 nfts
Nov 7, 2023
shahin-hq
reviewed
Nov 7, 2023
…thub.com/ArdentHQ/dashbrd into feat/prevent-selecting-more-than-16-nfts
alfonsobries
approved these changes
Nov 8, 2023
ItsANameToo
approved these changes
Nov 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[galleries] prevent users from selecting more than 16 NFTs
Summary
alreadyAddedNfts
+recentlySelectedNfts
to make sure this is<=
than the limit).NftImageContainer
component has been refactored to support this change.Steps to reproduce
local
ortesting_e2e
mode./galleries
page and click onCreate a gallery
button.Screen.Recording.2023-11-06.at.12.12.29.mov
Checklist