Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: ignore activity for invalid collections when refreshing NFT metadata #406

Merged
merged 2 commits into from
Nov 8, 2023

Conversation

crnkovic
Copy link
Contributor

@crnkovic crnkovic commented Nov 8, 2023

Summary

https://app.clickup.com/t/86dqhafcg

Even though the FetchCollectionActivity job will in fact check for supply, there's no need even to dispatch the job if we don't support activity for the collection (no supply, hard cap or blacklisted).

Checklist

  • I checked my UI changes against the design and there are no notable differences
  • I checked my UI changes for any responsiveness issues
  • I checked my (code) changes for obvious issues, debug statements and commented code
  • I opened a corresponding card on Clickup for any remaining TODOs in my code
  • I added a short description on how to test this PR (if necessary)
  • I added a storybook entry for the component that was added (if necessary)
  • Documentation (if necessary)
  • Tests (if necessary)
  • Ready to be merged

@crnkovic crnkovic changed the base branch from develop to rc-0.10.0 November 8, 2023 14:41
@ItsANameToo ItsANameToo added this to the 0.10.0 milestone Nov 8, 2023
@ItsANameToo ItsANameToo changed the title refactor: do not dispatch the activity job for invalid collections when refreshing NFT metadata refactor: ignore activity for invalid collections when refreshing NFT metadata Nov 8, 2023
@ItsANameToo ItsANameToo merged commit 1b56778 into rc-0.10.0 Nov 8, 2023
12 checks passed
@ItsANameToo ItsANameToo deleted the refactor/activities branch November 8, 2023 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants