Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: update progress bar color to primary brand color #424

Merged
merged 2 commits into from
Nov 10, 2023

Conversation

crnkovic
Copy link
Contributor

@crnkovic crnkovic commented Nov 9, 2023

Summary

Just something that was annoying me: the progress bar at the top when navigating through pages currently uses the default Tailwind gray color. I updated it to use our primary-700 color. Open for discussion.

Checklist

  • I checked my UI changes against the design and there are no notable differences
  • I checked my UI changes for any responsiveness issues
  • I checked my (code) changes for obvious issues, debug statements and commented code
  • I opened a corresponding card on Clickup for any remaining TODOs in my code
  • I added a short description on how to test this PR (if necessary)
  • I added a storybook entry for the component that was added (if necessary)
  • Documentation (if necessary)
  • Tests (if necessary)
  • Ready to be merged

@ItsANameToo ItsANameToo added this to the 0.10.0 milestone Nov 9, 2023
@ItsANameToo
Copy link
Contributor

I honestly have a hard time running into that loading bar when navigating the website

@ItsANameToo
Copy link
Contributor

for anyone else wanting to test this, enable throttling (fast 3G) in devtools if you don't get the loading bar when you navigate normally

@goga-m goga-m merged commit dcbc9bf into rc-0.10.0 Nov 10, 2023
12 checks passed
@goga-m goga-m deleted the refactor/progress-color branch November 10, 2023 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants