Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: add delete button to draft gallery #462

Merged
merged 20 commits into from
Nov 17, 2023

Conversation

crnkovic
Copy link
Contributor

Summary

https://app.clickup.com/t/86dqjt75x

Checklist

  • I checked my UI changes against the design and there are no notable differences
  • I checked my UI changes for any responsiveness issues
  • I checked my (code) changes for obvious issues, debug statements and commented code
  • I opened a corresponding card on Clickup for any remaining TODOs in my code
  • I added a short description on how to test this PR (if necessary)
  • I added a storybook entry for the component that was added (if necessary)
  • Documentation (if necessary)
  • Tests (if necessary)
  • Ready to be merged

@ItsANameToo ItsANameToo added this to the 0.11.0 milestone Nov 16, 2023
@crnkovic crnkovic marked this pull request as ready for review November 16, 2023 16:07
Copy link
Contributor

@alfonsobries alfonsobries left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not specified on the ticket but think we shold add the toast added here #463

@crnkovic
Copy link
Contributor Author

Not specified on the ticket but think we shold add the toast added here #463

good idea, added the toast

@alfonsobries
Copy link
Contributor

@crnkovic you are going to hate me sorry 😅

But on one of the tasks we removed the write DELETE to confirm when deleting drafts, so think we should do the same here
image

image

Copy link
Contributor

@ItsANameToo ItsANameToo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

when deleting a draft from the overview page, it shows the draft delete message. However, if you delete it from within the gallery it shows the regular delete gallery message instead. Both should show the draft message

overview:
image

when draft is open:
image

@ItsANameToo ItsANameToo marked this pull request as draft November 17, 2023 09:48
@crnkovic crnkovic marked this pull request as ready for review November 17, 2023 09:51
@ItsANameToo ItsANameToo merged commit 4326aa2 into develop Nov 17, 2023
14 checks passed
@ItsANameToo ItsANameToo deleted the refactor/delete-button branch November 17, 2023 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants