Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: do not disable create gallery button on gallery overview page #470

Conversation

patricio0312rev
Copy link
Contributor

@patricio0312rev patricio0312rev commented Nov 17, 2023

[galleries] create gallery button can be disabled on overview

Summary

  • New optional disableIfNoNfts prop for CreateGalleryButton component.
  • nftCount prop for CreateGalleryButton component is now optional since not every implementation will require it.
  • As a result, this button will never be disabled in the Gallery Overview Page.

Note: Initially I tested just making the nftCount optional and just checking if it wasn't undefined and it had a value different than 0. However, using isTruthy also checks if the number is different than 0. So I decided to be explicit with the prop.

## Steps to reproduce

  1. Run the app in local or testing_e2e mode.
  2. Make sure your wallet has no galleries created.
  3. Go to Galleries overview page (/galleries) and see the magic ✨

## Screenshots

  1. Gallery overview page (with no galleries created):
image
  1. Gallery overview page (with some galleries created):
image
  1. My galleries page (desktop):
image
  1. My galleries page (mobile):
image

Checklist

  • I checked my UI changes against the design and there are no notable differences
  • I checked my UI changes for any responsiveness issues
  • I checked my (code) changes for obvious issues, debug statements and commented code
  • I opened a corresponding card on Clickup for any remaining TODOs in my code
  • I added a short description on how to test this PR (if necessary)
  • I added a storybook entry for the component that was added (if necessary)
  • Documentation (if necessary)
  • Tests (if necessary)
  • Ready to be merged

@patricio0312rev patricio0312rev marked this pull request as ready for review November 17, 2023 13:19
@ItsANameToo ItsANameToo added this to the 0.11.0 milestone Nov 17, 2023
@patricio0312rev patricio0312rev changed the base branch from develop to rc-0.11.0 November 17, 2023 13:35
@ItsANameToo ItsANameToo changed the title fix: never disable create gallery button on gallery overview page fix: do not disable create gallery button on gallery overview page Nov 17, 2023
@ItsANameToo ItsANameToo merged commit 944a901 into rc-0.11.0 Nov 17, 2023
12 checks passed
@ItsANameToo ItsANameToo deleted the fix/never-disable-create-gallery-button-on-gallery-overview-page branch November 17, 2023 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants