Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: migrate getNftsForCollection to Alchemy v3 #471

Merged
merged 16 commits into from
Nov 28, 2023
Merged

refactor: migrate getNftsForCollection to Alchemy v3 #471

merged 16 commits into from
Nov 28, 2023

Conversation

shahin-hq
Copy link
Contributor

@shahin-hq shahin-hq commented Nov 17, 2023 •
edited
Loading

Summary

Depends on #468

Closes: https://app.clickup.com/t/86dqjv2nt

Checklist

  • I checked my UI changes against the design and there are no notable differences
  • I checked my UI changes for any responsiveness issues
  • I checked my (code) changes for obvious issues, debug statements and commented code
  • I opened a corresponding card on Clickup for any remaining TODOs in my code
  • I added a short description on how to test this PR (if necessary)
  • I added a storybook entry for the component that was added (if necessary)
  • Documentation (if necessary)
  • Tests (if necessary)
  • Ready to be merged

@ItsANameToo ItsANameToo added this to the 0.12.0 milestone Nov 17, 2023
@shahin-hq shahin-hq marked this pull request as ready for review November 21, 2023 09:14
@shahin-hq shahin-hq mentioned this pull request Nov 21, 2023
Merged
9 tasks
Base automatically changed from refactor/migrate-v3-getFloorPrice to develop November 22, 2023 09:05
@goga-m
Copy link
Contributor

goga-m commented Nov 22, 2023

Hey @shahin-hq just some coverage lines

@shahin-hq
Copy link
Contributor Author

@goga-m Please read the task description :)

@shahin-hq shahin-hq changed the base branch from develop to feat/alchemy-v3 November 22, 2023 11:26
goga-m
goga-m approved these changes Nov 23, 2023
View reviewed changes
Copy link
Contributor

@goga-m goga-m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM @shahin-hq 💯

@goga-m goga-m modified the milestones: 0.12.0, TBD Nov 23, 2023
@goga-m
Copy link
Contributor

goga-m commented Nov 23, 2023 •
edited
Loading

@ItsANameToo fyi changed the milestone to TBD as now all alchemy v3 PRs are merged into the feature branch. Please adjust if necessary. Ty!

@ItsANameToo
Copy link
Contributor

remove v2 as discussed

@ItsANameToo ItsANameToo marked this pull request as draft November 23, 2023 16:16
@shahin-hq shahin-hq mentioned this pull request Nov 24, 2023
Merged
9 tasks
@shahin-hq
Merge branch 'feat/alchemy-v3' into refactor/migrate-v3-getNFTsForCol…
8b2195b 
…lection

# Conflicts:
#	tests/fixtures/alchemy/get_nfts_for_contract.json
@shahin-hq shahin-hq marked this pull request as ready for review November 28, 2023 12:49
@shahin-hq shahin-hq merged commit 0db56c2 into feat/alchemy-v3 Nov 28, 2023
14 of 15 checks passed
@shahin-hq shahin-hq deleted the refactor/migrate-v3-getNFTsForCollection branch November 28, 2023 12:49
@ItsANameToo ItsANameToo modified the milestones: TBD, 0.12.0 Nov 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ItsANameToo ItsANameToo ItsANameToo approved these changes

@goga-m goga-m goga-m approved these changes

@crnkovic crnkovic crnkovic approved these changes

@samharperpittam samharperpittam Awaiting requested review from samharperpittam

@boldninja boldninja Awaiting requested review from boldninja

Assignees
No one assigned
Labels
refactor
Projects
None yet
Milestone
0.12.0
Development

Successfully merging this pull request may close these issues.
4 participants
@shahin-hq @goga-m @ItsANameToo @crnkovic