Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: delete draft if empty when navigating away #473

Merged
merged 9 commits into from
Nov 21, 2023

Conversation

goga-m
Copy link
Contributor

@goga-m goga-m commented Nov 17, 2023

Summary

Closes https://app.clickup.com/t/86dqk1uey

Checklist

  • I checked my UI changes against the design and there are no notable differences
  • I checked my UI changes for any responsiveness issues
  • I checked my (code) changes for obvious issues, debug statements and commented code
  • I opened a corresponding card on Clickup for any remaining TODOs in my code
  • I added a short description on how to test this PR (if necessary)
  • I added a storybook entry for the component that was added (if necessary)
  • Documentation (if necessary)
  • Tests (if necessary)
  • Ready to be merged

@goga-m goga-m changed the title fix: delete if empty when navigating away fix: delete draft if empty when navigating away Nov 17, 2023
Copy link
Contributor

@alfonsobries alfonsobries left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems that a new bug was introduced on this pr (i cant replicate the error in rc-0.11.9)

To test:

  1. remove all drafts (this step may not be necessary but was my specific case)
  2. create a new gallery and add nfts
  3. see that draft saved
  4. cancel and see that draft is not stored
Screen.Recording.2023-11-17.at.11.01.17.a.m.mov

@ItsANameToo ItsANameToo added this to the 0.11.0 milestone Nov 18, 2023
@goga-m goga-m marked this pull request as draft November 20, 2023 12:05
@goga-m goga-m marked this pull request as ready for review November 20, 2023 13:48
@goga-m
Copy link
Contributor Author

goga-m commented Nov 20, 2023

@alfonsobries it should be fixed now. Thanks 💯

@crnkovic crnkovic assigned crnkovic and alfonsobries and unassigned crnkovic Nov 21, 2023
@crnkovic crnkovic self-assigned this Nov 21, 2023
@crnkovic crnkovic merged commit 96f9f9a into rc-0.11.0 Nov 21, 2023
12 checks passed
@crnkovic crnkovic deleted the fix/draft-cleanup branch November 21, 2023 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants