-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: delete draft if empty when navigating away #473
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
goga-m
changed the title
fix: delete if empty when navigating away
fix: delete draft if empty when navigating away
Nov 17, 2023
alfonsobries
requested changes
Nov 17, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
seems that a new bug was introduced on this pr (i cant replicate the error in rc-0.11.9
)
To test:
- remove all drafts (this step may not be necessary but was my specific case)
- create a new gallery and add nfts
- see that draft saved
- cancel and see that draft is not stored
Screen.Recording.2023-11-17.at.11.01.17.a.m.mov
@alfonsobries it should be fixed now. Thanks 💯 |
crnkovic
approved these changes
Nov 20, 2023
samharperpittam
approved these changes
Nov 21, 2023
alfonsobries
approved these changes
Nov 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Closes https://app.clickup.com/t/86dqk1uey
Checklist