-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: featured collections carousel #494
feat: featured collections carousel #494
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On mobile, the carousel can be different heights depending if a Collection description is displayed or not. Might be worth using a fixed height at all time. See video
Screen.Recording.2023-11-24.at.12.30.42.mov
Fixes have been implemented 💜 Screen.Recording.2023-11-24.at.09.57.09.mov |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@patricio0312rev overall looks good 💯
Similar to Sam's finding, also noticed is that in smaller screens when you have 1 nft it occupies all the available space which results in having different heights when you have slides that have > 1 nft along with those with only 1 nft
And with more (also notice that gap that this one has, it's because the slider takes the height of the highest slide):
Perhaps it makes sense to limit the size of the nft card to be as when there are multiple, so that we have the same heights when changing slides 🤔
@goga-m pretty sure we fixed that this morning. Did you pull latest changes? 👀 😰 |
@patricio0312rev indeed didn't have the latest changes when tested. Looking good 💯 slider-2023-11-27_10.38.27.mp4 |
[featured collections] add featured collections slider
Summary
/collections
overview page.NftSeeder
has been updated to add support fordescription
andis_featured
fields.CollectionFeaturedData
data type that will be used to get the new data structure for featured collections.featured-collections-overlay
class name has been added, to add support for the gradient for our featured collections card's background.GridHeader
. It now supports customwrapperClassNames
.CollectionNft
card now supports custom class names.FeaturedCollectionsCarousel
andFeaturedCollectionsItem
components.FormatCrypto
component now supportsmaximumFractionDigits
.autoplay
effect has been added to our carousel. It will change the slide every 5 secs.Steps to reproduce
local
ortesting_e2e
mode.composer db:dev
./admin
portal.Collections
and mark asfeatured
3 or 4 collections./collections
page and see the magic ✨Screen.Recording.2023-11-23.at.10.07.30.mov
Checklist