Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add padding for galleries and draft cards in my galleries page #512

Merged

Conversation

patricio0312rev
Copy link
Contributor

[my galleries] content width borked on mobile

Summary

  • Paddings have been fixed for galleries and draft cards in mobile view. It now matches the design.

Steps to reproduce

  1. Run the app in local or testing_e2e mode.
  2. Make sure your wallet is connected.
  3. Create at least 1 gallery and 1 draft.
  4. Go to /my-galleries page and see the magic ✨
image

Checklist

  • I checked my UI changes against the design and there are no notable differences
  • I checked my UI changes for any responsiveness issues
  • I checked my (code) changes for obvious issues, debug statements and commented code
  • I opened a corresponding card on Clickup for any remaining TODOs in my code
  • I added a short description on how to test this PR (if necessary)
  • I added a storybook entry for the component that was added (if necessary)
  • Documentation (if necessary)
  • Tests (if necessary)
  • Ready to be merged

@patricio0312rev patricio0312rev marked this pull request as ready for review November 27, 2023 13:35
@crnkovic crnkovic self-assigned this Nov 27, 2023
Copy link

@samharperpittam samharperpittam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@patricio0312rev - seems there's still an issue with placeholders.
image

@samharperpittam samharperpittam marked this pull request as draft November 27, 2023 13:50
@samharperpittam samharperpittam marked this pull request as ready for review November 27, 2023 13:58
@crnkovic crnkovic merged commit 65b0570 into rc-0.11.0 Nov 27, 2023
14 checks passed
@crnkovic crnkovic deleted the fix/padding-for-galleries-and-drafts-in-my-galleries-page branch November 27, 2023 14:06
@ItsANameToo ItsANameToo added this to the 0.11.0 milestone Nov 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants