Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: winner overview #524

Merged
merged 24 commits into from
Dec 1, 2023
Merged

Conversation

alfonsobries
Copy link
Contributor

@alfonsobries alfonsobries commented Nov 30, 2023

Summary

Closes https://app.clickup.com/t/86dqnpf7q

Notice that the collections, the votes for each collection are randomly loaded and the month is hardcoded, we need to update that once we implement the vote system

To test you can change the ->limit on the controller (app/Http/Controllers/CollectionController.php) to (0, 1, 2 or 3) which should show different amount of bars or the placeholder in the case of setting to 0

'topCollections' => fn () => CollectionOfTheMonthData::collection(Collection::query()->inRandomOrder()->limit(3)->get()),

Checklist

  • I checked my UI changes against the design and there are no notable differences
  • I checked my UI changes for any responsiveness issues
  • I checked my (code) changes for obvious issues, debug statements and commented code
  • I opened a corresponding card on Clickup for any remaining TODOs in my code
  • I added a short description on how to test this PR (if necessary)
  • I added a storybook entry for the component that was added (if necessary)
  • Documentation (if necessary)
  • Tests (if necessary)
  • Ready to be merged

@alfonsobries alfonsobries marked this pull request as ready for review November 30, 2023 16:44
@alfonsobries alfonsobries changed the title [wip] feat: winner overview feat: winner overview Nov 30, 2023
Copy link
Contributor

@ItsANameToo ItsANameToo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good on desktop, but no responsiveness yet. Will add a new card for that so this can get merged

<CollectionOfTheMonthWinners className="hidden xl:flex" />

<CollectionOfTheMonthWinners
className="hidden xl:flex"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sad

resources/js/Pages/Collections/Index.tsx Outdated Show resolved Hide resolved
@ItsANameToo ItsANameToo merged commit 8b8af67 into feat/collections-overview Dec 1, 2023
16 checks passed
@ItsANameToo ItsANameToo deleted the feat/winner-overview branch December 1, 2023 09:58
@ItsANameToo ItsANameToo added this to the 0.13.0 milestone Dec 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants