-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: winner overview #524
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rd into feat/winner-overview
…to feat/winner-overview
alfonsobries
requested review from
samharperpittam and
boldninja
as code owners
November 30, 2023 16:44
ItsANameToo
approved these changes
Dec 1, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good on desktop, but no responsiveness yet. Will add a new card for that so this can get merged
<CollectionOfTheMonthWinners className="hidden xl:flex" /> | ||
|
||
<CollectionOfTheMonthWinners | ||
className="hidden xl:flex" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sad
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Closes https://app.clickup.com/t/86dqnpf7q
Notice that the collections, the votes for each collection are randomly loaded and the month is hardcoded, we need to update that once we implement the vote system
To test you can change the
->limit
on the controller (app/Http/Controllers/CollectionController.php
) to (0, 1, 2 or 3) which should show different amount of bars or the placeholder in the case of setting to0
Checklist