Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add footer cta #526

Merged
merged 9 commits into from
Dec 4, 2023

Conversation

crnkovic
Copy link
Contributor

@crnkovic crnkovic commented Dec 1, 2023

Summary

https://app.clickup.com/t/86dqpd227

Checklist

  • I checked my UI changes against the design and there are no notable differences
  • I checked my UI changes for any responsiveness issues
  • I checked my (code) changes for obvious issues, debug statements and commented code
  • I opened a corresponding card on Clickup for any remaining TODOs in my code
  • I added a short description on how to test this PR (if necessary)
  • I added a storybook entry for the component that was added (if necessary)
  • Documentation (if necessary)
  • Tests (if necessary)
  • Ready to be merged

@crnkovic crnkovic marked this pull request as ready for review December 1, 2023 15:21
@alfonsobries alfonsobries self-assigned this Dec 1, 2023
Copy link
Contributor

@alfonsobries alfonsobries left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

UPDATE: was a quick fix so fixed for you @crnkovic you can ignore

UPDATE 2: my change was rejected, you were fast 😄

Design uses a white browser as the illustration on light mode but implementation shows a dark one

Design
image

Implementation

image

Copy link
Contributor

@alfonsobries alfonsobries left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👌

Copy link
Contributor

@shahin-hq shahin-hq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 good job

@shahin-hq shahin-hq self-assigned this Dec 1, 2023
@ItsANameToo ItsANameToo added this to the 0.13.0 milestone Dec 4, 2023
@ItsANameToo ItsANameToo merged commit 6db9656 into feat/collections-overview Dec 4, 2023
16 checks passed
@ItsANameToo ItsANameToo deleted the refactor/call-to-actions branch December 4, 2023 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants