-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add collections table voted state #532
Merged
ItsANameToo
merged 37 commits into
feat/collections-overview
from
feat/collections-table-voted-state
Dec 6, 2023
Merged
feat: add collections table voted state #532
ItsANameToo
merged 37 commits into
feat/collections-overview
from
feat/collections-table-voted-state
Dec 6, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…able # Conflicts: # resources/js/Pages/Collections/Components/CollectionOfTheMonth/CollectionOfTheMonth.tsx # resources/js/Pages/Collections/Index.tsx
…o feat/collections-vote-table # Conflicts: # resources/js/Pages/Collections/Components/CollectionVoting/VoteCollections.tsx
…o feat/collections-vote-table
…able # Conflicts: # resources/js/I18n/Locales/en.json # resources/js/Pages/Collections/Components/CollectionOfTheMonth/CollectionOfTheMonth.tsx # resources/js/Pages/Collections/Components/CollectionOfTheMonth/VoteCollection.tsx # resources/js/Pages/Collections/Index.tsx
shahin-hq
changed the title
feat: add collection table voted state
feat: add collections table voted state
Dec 4, 2023
Base automatically changed from
feat/collections-vote-table
to
feat/collections-overview
December 5, 2023 09:04
…e-voted-state # Conflicts: # resources/js/Pages/Collections/Components/CollectionVoting/VoteCollections.tsx
…voted-state # Conflicts: # resources/css/app.css # resources/js/Pages/Collections/Components/CollectionVoting/VoteCollections.tsx # resources/js/Pages/Collections/Index.tsx # resources/js/icons.tsx
shahin-hq
commented
Dec 5, 2023
@@ -145,6 +147,7 @@ const CollectionsIndex = ({ | |||
</div> | |||
<div className="mt-12 flex w-full flex-col gap-4 xl:flex-row"> | |||
<VoteCollections | |||
votedCollectionId={1} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
set this to undefined
to see non-voted states
ItsANameToo
approved these changes
Dec 5, 2023
…voted-state # Conflicts: # resources/js/I18n/Locales/en.json
crnkovic
approved these changes
Dec 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Closes: https://app.clickup.com/t/86dqnpfvg
Design: https://www.figma.com/file/2Rr7zzoeGGiHYsROvfHaGe/Dashboard?node-id=23916%3A101569&mode=dev
Checklist