Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: vote received modal #533

Merged
merged 14 commits into from
Dec 7, 2023

Conversation

alfonsobries
Copy link
Contributor

Summary

Closes

https://app.clickup.com/t/86dqnpgd9

note: this pr adds a temporal button that can be used to open the modal, since the interaction that eventually are going to trigger that modal are not ready
image

Checklist

  • I checked my UI changes against the design and there are no notable differences
  • I checked my UI changes for any responsiveness issues
  • I checked my (code) changes for obvious issues, debug statements and commented code
  • I opened a corresponding card on Clickup for any remaining TODOs in my code
  • I added a short description on how to test this PR (if necessary)
  • I added a storybook entry for the component that was added (if necessary)
  • Documentation (if necessary)
  • Tests (if necessary)
  • Ready to be merged

@alfonsobries alfonsobries changed the base branch from develop to feat/collections-overview December 4, 2023 22:40
@ItsANameToo ItsANameToo added this to the 0.13.0 milestone Dec 5, 2023
@crnkovic crnkovic self-assigned this Dec 6, 2023
Copy link
Contributor

@crnkovic crnkovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you ran the images through the tinypng compression? 400 KB and 500 KB seems kinda "large"

@shahin-hq shahin-hq self-assigned this Dec 6, 2023
Copy link

@samharperpittam samharperpittam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems this aspect of the spec is missing when sharing on X

<collection> - either the twitter username (@collection) if they have one, otherwise turn it into a tag based on the collection name (all lowercase, no spaces, e.g. #alphadogs)

@samharperpittam samharperpittam marked this pull request as draft December 6, 2023 11:04
@alfonsobries
Copy link
Contributor Author

@shahin-hq @crnkovic @samharperpittam feedback handled, added a second button to test a dummy collection with twitter account and without twitter account
image

@alfonsobries alfonsobries marked this pull request as ready for review December 6, 2023 17:40
@crnkovic crnkovic merged commit 4a63945 into feat/collections-overview Dec 7, 2023
16 checks passed
@crnkovic crnkovic deleted the feat/vote-received-modal branch December 7, 2023 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants