Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: move authentication overlay to the nomination modal #603

Merged
merged 5 commits into from
Jan 18, 2024

Conversation

crnkovic
Copy link
Contributor

Summary

https://app.clickup.com/t/86dr5c195

Depends on #602

Checklist

  • I checked my UI changes against the design and there are no notable differences
  • I checked my UI changes for any responsiveness issues
  • I checked my (code) changes for obvious issues, debug statements and commented code
  • I opened a corresponding card on Clickup for any remaining TODOs in my code
  • I added a short description on how to test this PR (if necessary)
  • I added a storybook entry for the component that was added (if necessary)
  • Documentation (if necessary)
  • Tests (if necessary)
  • Ready to be merged

@ItsANameToo ItsANameToo added this to the 0.13.0 milestone Jan 16, 2024
@crnkovic crnkovic marked this pull request as ready for review January 17, 2024 09:37
@crnkovic crnkovic marked this pull request as draft January 17, 2024 09:38
@crnkovic crnkovic marked this pull request as ready for review January 17, 2024 09:38
@ItsANameToo ItsANameToo merged commit 321f98c into develop Jan 18, 2024
14 checks passed
@ItsANameToo ItsANameToo deleted the refactor/voting-auth branch January 18, 2024 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants