Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: do not use deprecated mnemonic APIs #632

Merged
merged 8 commits into from
Jan 30, 2024

Conversation

crnkovic
Copy link
Contributor

@crnkovic crnkovic commented Jan 25, 2024

Summary

https://app.clickup.com/t/86drb9y31

To test, run the following (before and after this PR) commands, and test that they do what they should do. Before these changes, they'll probably throw some kind of error.

php artisan collections:fetch-owners

php artisan collections:fetch-banner --collection-id={someCollection}

Checklist

  • I checked my UI changes against the design and there are no notable differences
  • I checked my UI changes for any responsiveness issues
  • I checked my (code) changes for obvious issues, debug statements and commented code
  • I opened a corresponding card on Clickup for any remaining TODOs in my code
  • I added a short description on how to test this PR (if necessary)
  • I added a storybook entry for the component that was added (if necessary)
  • Documentation (if necessary)
  • Tests (if necessary)
  • Ready to be merged

@crnkovic crnkovic marked this pull request as ready for review January 25, 2024 16:04
Copy link
Contributor

@patricio0312rev patricio0312rev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🌟

@crnkovic crnkovic merged commit 2b5d63b into develop Jan 30, 2024
12 checks passed
@crnkovic crnkovic deleted the refactor/mnemonic-endpoints branch January 30, 2024 08:53
@ItsANameToo ItsANameToo modified the milestones: 0.14.0, 0.13.0 Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants