refactor: add composite (collection_id, deleted_at) index to nfts
table
#635
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
https://app.clickup.com/t/86drc7q7m
Prior to this change, it would take around ~500ms to execute a query to retrieve the popular collections on the
/collections
page if there are around 1M NFTs in the table. With this index, it's down to ~90ms. And we have much more than 1M NFTs on staging/prod, thus I can see it taking much longer in prod/staging.It may not be an ideal query, but it's still an improvement.
Checklist