fix: caching the opensea response causing the TypeError
when deserializing
#661
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
https://app.clickup.com/t/86drgahvk
The problem is that we used to cache the entire OpenSea response, which is serialized and put into Redis, then deserialized. It can't properly be deserialized, and thus failed. We can cache the JSON response, though. That can be serialized with no issues.
As a bonus, I inlined the OpenSea API URL and the version as there is no more v1.
What we did:
What we need to do:
When testing and after deployment, please clear cache:
php artisan cache:clear
To test, set cache driver to redis, open tinker, and run the following code twice
Opensea::getCollectionFloorPrice('proof-moonbirds')
.Clear cache and try again after this PR.
Checklist