refactor: avoid isTruthy
call in places where it's not needed
#668
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
https://app.clickup.com/t/86drj8rbd
There are some places in React where we have some value be either some object or
null
. We can avoid calls toisTruthy
in these situations as it's simple enough to check whether some value isnull
orundefined
.Also, if some component prop is an optional boolean, we can default to
false
, such as in theTextInput
component, to avoid this prop being possiblyundefined
.For example:
Just uses more TypeScript to make a nicer developer experience.
Checklist