Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: use total volume for featured collections and remove volume column #683

Merged
merged 9 commits into from
Mar 12, 2024

Conversation

crnkovic
Copy link
Contributor

@crnkovic crnkovic commented Feb 26, 2024

Summary

https://app.clickup.com/t/86dru7rap

Checklist

  • I checked my UI changes against the design and there are no notable differences
  • I checked my UI changes for any responsiveness issues
  • I checked my (code) changes for obvious issues, debug statements and commented code
  • I opened a corresponding card on Clickup for any remaining TODOs in my code
  • I added a short description on how to test this PR (if necessary)
  • I added a storybook entry for the component that was added (if necessary)
  • Documentation (if necessary)
  • Tests (if necessary)
  • Ready to be merged

@ItsANameToo
Copy link
Contributor

card for this?

@crnkovic crnkovic marked this pull request as ready for review March 7, 2024 14:52
@ItsANameToo ItsANameToo changed the title refactor: use total volume in a featured collection and remove the volume column from the collections table refactor: use total volume for featured collections and remove volume column Mar 12, 2024
@ItsANameToo ItsANameToo merged commit 84054ac into develop Mar 12, 2024
16 checks passed
@ItsANameToo ItsANameToo deleted the refactor/featured-total-volume branch March 12, 2024 09:57
@ItsANameToo ItsANameToo added this to the 0.14.0 milestone Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants