-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add network filter to collections overview #81
Conversation
Possible issues and suggestions
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The card specifies to disable the checkbox if there are no collections for the network, but I can still toggle it:
Also, if you hide a collection, it will still display the total number of collections per network, including hidden ones. It should probably take into account only collections based on shown/hidden state (hidden = show only hidden count per network and vice versa). cc @samharperpittam.
EDIT: Ah, I have noticed that the shown/hidden bug only happens if you re-toggle "showHidden". If I refresh the page, the counts are okay.
Yeah I agree with this |
Something is screwed up with counts when showing/hiding 😂 Screen.Recording.2023-09-15.at.14.08.57.mov |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
still have some issues with the filter notification:
-
if you only own NFTs for one network, it will indicate it's filtered even though it technically shows all your NFTs
-
when you have all networks selected and toggle "show hidden", then deselect all networks and untoggle "show hidden" you are now in a state where you can't get rid of the nofitication dot anymore
-
when the page loads the NFTs, it briefly shows the filter as active before it removes the notification dot. Mainly noticeable when the user owns a lot of NFTs or if the user has no NFTs at all
resources/js/Pages/Collections/Components/CollectionsFilter/CollectionsFilterPopover.tsx
Outdated
Show resolved
Hide resolved
resources/js/Pages/Collections/Components/CollectionsFilter/CollectionsFilterPopover.tsx
Outdated
Show resolved
Hide resolved
resources/js/Pages/Collections/Components/CollectionsFilter/CollectionsFilterPopover.tsx
Outdated
Show resolved
Hide resolved
…llectionsFilterPopover.tsx Co-authored-by: ItsANameToo <35610748+ItsANameToo@users.noreply.github.com>
[collections] Add filter option per network
Summary
How is it done?
view
function fromCollectionController
, a new filter for thechain
query param has been added.chain_ids
and filter our collections in case we have 1 or more ids in the array.Changes
NetworkWithCollectionsData
data constructor has been created to help us get the collections count for each network and get the correct typing.pages.php
CollectionsNetworksFilter
component to contain all the filters.Screen.Recording.2023-09-12.at.16.48.12.mov
Checklist