SRTM: migrate to terrain.ardupilot.org #3025
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The 1-arcsec SRTM data on firmware.ardupilot.org is copied from the old usgs.gov dataset, which has some large holes in coverage. If you are operating in one of these holes, Mission Planner does not fall back to the 3-arcsec data, because it merely checks for the existence of a .hgt file for that region, and if it does, assumes there is 1-arcsec coverage for the whole area in that file.
The 1-arcsec data on terrain.ardupilot.org is from JAXA's ALOS dataset, and does not have these invalid regions (at least, not that I can find). Another benefit is that it covers most of the world, and not just the US.
To reproduce this set your map on the plan page to 29.844, -82.040 (in Florida). Everything in the immediate area is "Invalid". After applying the changes in this PR, it comes through.
The only thing I'm not sure of is whether it's okay to use the terrain.ardupilot.org server for this, from a number-of-requests standpoint. Hopefully @tridge could chime in on that.