GCSViews: ConfigurationView: Motor test: use JSON file to add more infromation #3043
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IamPete1
commented
Jan 14, 2023
IamPete1
force-pushed
the
motor_test_info
branch
from
2a0299f to
547819b
Compare
|
Rebased and now includes the json file correctly, I might have gone overboard and included it in more places than needed, but it seems to work. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Firstly this grabs the frame type and class from param meta data. Secondly it disaplays the motor number and rotation direction by looking it up in a json file (which I have not worked out how to include correctly).
With more motors:
Ultimately I would like to programmatically generate the diagram, but that is a bit too much for me. I would like to end up with a interface that will re-odder your motors correctly, you would test motor A and then click on the diagram which motor actually spun and it would switch them round until your ordering is correct.
The json file is generated by a modified AP motors example, it only has all the matrix types. We could update it to include tricopters and other unusual frame types by hand.