mavcmd: update do-digicam-control fields #3139
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This renames the "On/Off" field of the DO_DIGICAM_CONTROL command to "Session Control" which better matches the mavlink spec and, I hope, will reduce confusion with the "Shutter Control" field which is what most users actually need to set.
This has been lightly tested on my desktop and the before and after shots are shown below.
BEFORE:
![image](https://private-user-images.githubusercontent.com/1498098/248670250-0bba53df-a1c6-4ba5-b3ba-2fd42ad70b20.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzkxMDg0MjIsIm5iZiI6MTczOTEwODEyMiwicGF0aCI6Ii8xNDk4MDk4LzI0ODY3MDI1MC0wYmJhNTNkZi1hMWM2LTRiYTUtYjNiYS0yZmQ0MmFkNzBiMjAucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI1MDIwOSUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNTAyMDlUMTMzNTIyWiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9NWJkN2ExODQ5YTdkMzMzMTNhNjRkZDU3YTlkZjVmZmU4NzYzMWYzYjMwYjk3OGJjYjdhNTQ3NDljNzVhYzFiMyZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QifQ.86K_A4f4Vs-XxOr70ljKILdzX1rUdWOq3u0u9k3rOZA)
AFTER:
![image](https://private-user-images.githubusercontent.com/1498098/248670115-0200aac3-d2f8-4dfa-bd33-cb012cca54f9.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzkxMDg0MjIsIm5iZiI6MTczOTEwODEyMiwicGF0aCI6Ii8xNDk4MDk4LzI0ODY3MDExNS0wMjAwYWFjMy1kMmY4LTRkZmEtYmQzMy1jYjAxMmNjYTU0ZjkucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI1MDIwOSUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNTAyMDlUMTMzNTIyWiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9ZGQzMzZmYjBmMzExZDliNjlkMmZlOTIwOWFmNmIyMDFkZDBlNmFiYmU2MmIyMGVjMDI2MmY1Njc1MjU4NjYyZCZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QifQ.L4XUAnPiu1FkyN91bK6WndlWhSkPKM812uCWVRPSJTQ)
Thanks to @CraigElder for reporting this issue.