Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup: SerialPort settings screen #3240

Merged
merged 3 commits into from
Nov 28, 2023
Merged

Conversation

EosBandi
Copy link
Collaborator

Collects all information about serial ports on a single screen. Using rules defined in the SerialOptionRules.json to add comments and set mandatory options/baudrate when a certain protocol selected.

@rmackay9
Copy link
Contributor

This sounds like a good idea, thanks!

@meee1
Copy link
Contributor

meee1 commented Nov 21, 2023

can i request a screenshot?

@EosBandi
Copy link
Collaborator Author

Sorry, sure.
image

@rmackay9
Copy link
Contributor

rmackay9 commented Nov 21, 2023

I'm not an official reviewer of MP PRs of course but where does the 2nd line, "UART2", etc come from?

I wonder if we could add the BRD_SER1/2_RTSCTS params alongside SERIAL1 and SERIAL2? This is scope creep though, so just a suggestion.

@rmackay9
Copy link
Contributor

I'd also use "baud" instead of "speed". I know that "speed" is perhaps more understandable to the lay user but we should try and avoid synonyms I think.

@rmackay9
Copy link
Contributor

Sorry for the drip-feed of suggestions.. but just one more, in terms of where it appears in the "Mandatory Hardware" section, I'd probably say it should go lower in the list... perhaps just below "Servo Output".

@EosBandi
Copy link
Collaborator Author

EosBandi commented Nov 22, 2023

I'm not an official reviewer of MP PRs of course but where does the 2nd line, "UART2", etc come from?

I wonder if we could add the BRD_SER1/2_RTSCTS params alongside SERIAL1 and SERIAL2? This is scope creep though, so just a suggestion.

  • UART numbers are coming from the @sys/uarts.txt (if available), an idea from Andy Piper.
  • BRD_SER_RTSCTS can be added; let me take a look at it... (or keep it to the next version ?)
  • It can go down, no problem,
  • Speed and baud are used interchangeably in the documentation with a favor for the term speed instead of baud rate. (Not to mention that baud is the unit of the serial speed :) )

Add BRD_SERx_RTSCTS check
Increase cell sizes to decrease clutter
@EosBandi
Copy link
Collaborator Author

Moved tab down below Servo Outputs
Add checking and displaying BRD_SERx_RTSCTS settings
Make it a little less cluttered
image

@meee1 meee1 merged commit 77451af into ArduPilot:master Nov 28, 2023
5 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants