AP_Mount: all backends send gimbal-device-attitude-status #21243
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peterbarker
reviewed
Jul 21, 2022
rmackay9
force-pushed
the
mount-fix-msgs
branch
4 times, most recently
from
1507d92 to
c7ae769
Compare
rmackay9
force-pushed
the
mount-fix-msgs
branch
from
c7ae769 to
c404683
Compare
tridge
previously requested changes
Aug 8, 2022
peterbarker
previously requested changes
Aug 8, 2022
rmackay9
force-pushed
the
mount-fix-msgs
branch
2 times, most recently
from
ec4f837 to
ecdd80c
Compare
rmackay9
dismissed stale reviews from peterbarker and tridge
I've resolved issues raised by PeterB
add set_mount_mode to reduce duplication remove reliance on GIMBAL_REPORT slightly loosen accuracy of mount pitch test
rmackay9
force-pushed
the
mount-fix-msgs
branch
from
ecdd80c to
e8d639f
Compare
tridge
approved these changes
Aug 16, 2022
peterbarker
approved these changes
Aug 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates all backends to send the GIMBAL_DEVICE_ATTITUDE_STATUS message instead of the older ardupilot specific MOUNT_STATUS message.
Some other changes are also included:
This has been tested in SITL for servo and Gremsy backends to ensure they send the correct messages. We currently have no way to test the other gimbal drivers (Solo, SToRM32 serial and mavlink, AlexMos serial) but they should be fine.
