autotest: large outliers in sub terrain test have low sq #27684
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ptrmu Please take a look |
|
Just a note. No test failures are acceptable - the test must be 100% (as-designed ;-) ), even in the face of adding random noise. People seem to have this thing against flapping tests :-) |
|
@peterbarker got it! I pushed another commit (I'll squash later), this should eliminate all test failures:
|
clydemcqueen
force-pushed
the
fix_sub_terrain_test
branch
from
c99717d
to
b86871a
Compare
|
Looks great! |
clydemcqueen
force-pushed
the
fix_sub_terrain_test
branch
from
b86871a
to
e28e0a3
Compare
clydemcqueen
force-pushed
the
fix_sub_terrain_test
branch
from
e28e0a3
to
9b4157c
Compare
peterbarker
approved these changes
Sep 20, 2024
|
Merged, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current test.Sub.SimTerrainSurftrak noise configuration is causing
moretest failuresthan we'd like.This PR adds
outlier_good_sq_limitto the configuration. If the error exceedsoutlier_good_sq_limitthen the signal quality drops from 100 (best) to 50 (bad).Sub::read_rangefinder()tests for this, so large outliers are rejected. This shouldminimizeeliminate test failures, and it also exercises the sq test inSub::read_rangefinder().Edit: I also fixed some test names and a few typos