Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AP_DDS: Correct compilation of tests without external odom #28141

Merged
merged 1 commit into from
Sep 19, 2024
Merged

AP_DDS: Correct compilation of tests without external odom #28141

merged 1 commit into from
Sep 19, 2024

Conversation

Ryanf55
Copy link
Collaborator

@Ryanf55 Ryanf55 commented Sep 18, 2024 •
edited
Loading

Addresses #28123 (comment)

./waf configure --enable-dds --disable-VISUALODOM
./waf tests
./build/sitl/tests/test_ap_dds_external_odom
echo $?

@Ryanf55
AP_DDS: Correct compilation of tests without external odom
9d1a1b1 
Signed-off-by: Ryan Friedman <ryanfriedman5410+github@gmail.com>
@Ryanf55 Ryanf55 added the ROS label Sep 18, 2024
peterbarker
peterbarker approved these changes Sep 18, 2024
View reviewed changes
Copy link
Contributor

@peterbarker peterbarker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@peterbarker peterbarker merged commit aecb326 into ArduPilot:master Sep 19, 2024
95 checks passed
@Ryanf55 Ryanf55 deleted the dds-correct-test-compilation-without-external-odom branch September 21, 2024 01:42
@Ryanf55 Ryanf55 mentioned this pull request Sep 21, 2024
Merged
@rmackay9
Copy link
Contributor

this has been included in Copter-4.5.7-beta1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peterbarker peterbarker peterbarker approved these changes

Assignees
No one assigned
Labels
MergeOnCIPass ROS
Projects
4.5 Backports
Status: 4.5.7-beta1
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Ryanf55 @rmackay9 @peterbarker