Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add LUA AP_TemperatureSensor bindings #28143

Conversation

peterbarker
Copy link
Contributor

... and an example

image

Testing #26886

@peterbarker
Copy link
Contributor Author

@rahulOCR Something odd going on here. get_temperature should be returning degrees-celsius, so the conversion I'm putting in here is incorrect.

Any ideas?

@peterbarker peterbarker force-pushed the pr/scripting-temperaturesensor-bindings branch 2 times, most recently from 247bea1 to 5f26b5d Compare September 19, 2024 09:28
@rahulOCR
Copy link
Contributor

rahulOCR commented Sep 19, 2024

get_temperature will return in degrees-celsius. can you let me know what odd is going on ?

@peterbarker peterbarker force-pushed the pr/scripting-temperaturesensor-bindings branch from 5f26b5d to 1b6c86b Compare September 19, 2024 12:30
@peterbarker
Copy link
Contributor Author

Rebased on top of @rahulOCR 's fix (thanks!).

@peterbarker peterbarker force-pushed the pr/scripting-temperaturesensor-bindings branch from 1b6c86b to 8fad896 Compare September 21, 2024 22:47
Copy link
Member

@IamPete1 IamPete1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@peterbarker
Copy link
Contributor Author

Thanks @IamPete1 , merging.

@peterbarker peterbarker merged commit 44c1e9b into ArduPilot:master Sep 22, 2024
96 checks passed
@peterbarker peterbarker deleted the pr/scripting-temperaturesensor-bindings branch September 23, 2024 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants