-
Notifications
You must be signed in to change notification settings - Fork 17.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Plane: add Autoland mode #28771
base: master
Are you sure you want to change the base?
Plane: add Autoland mode #28771
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Love this idea - some suggestions.
Very interesting, I would instead have a suggestion for a much more solid approach in my opinion, since yours is great for taxiing takeoffs but not for hand launches, which is often not necessarily the direction of the runway. Instead, here is what I propose, in my opinion the most logical and hyper simple: if there was the possibility in Ardupilot to fix two points on the runway, to indicate LR of the correct axis would be more than enough to tell Ardupilot to use that line to perform any kind of LAND, so something like this. In this very simple approach Ardupilot knows of the runway the direction, the center and the correct length, so he knows that that is the runway in all its useful aspects. |
@robustini many people never use MP after initial setup and arent comfortable with mission planning....I never use missions other than autotakeoff/do-land-start/landing sequence with my mission selector app to select land direction for my field based on wind direction....or my UniversalAutoLand lua when travelling to other locations this is the C++ implementation of my UniversalAutoLand lua script which I use when traveling and just stop at a location and fly...no laptop used.. |
fcf710d
to
a1b1b13
Compare
Should this be disabling fences (autoenabled, and floor) when doing a landing? |
It does a NAV_LAND....so whatever it does or does not |
b4a7cc2
to
e9b36f1
Compare
60a6dc9
to
64d7e89
Compare
dc09056
to
9cba0f3
Compare
6a4445c
to
436b498
Compare
9d61421
to
aaf9c45
Compare
Added AUTOLAND_DIR_OFS param to rotate the landing direction from takeoff direction as requested.... Test flown today without any issues... |
712f06c
to
3c4dd0f
Compare
ArduPlane/mode_autoland.cpp
Outdated
if (quadplane.available()) { | ||
gcs().send_text(MAV_SEVERITY_WARNING, "AutoLand is fixed wing only mode"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should permit the use of this mode if the Q_OPTION bit is set to allow fixed-wing landings.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fine by me and easy to do, but @tridge was the one who asked me to prevent Qplanes from using this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
He reminded me the Q_OPTION bit existed :-)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@peterbarker thanks for the flight testing! added the ability to use this mode in QPlane if option is set....also landing auto-flaps WAS working, although incorrectly: they were activated immediately upon mode entry while flying to final waypoint...the last commit (unsquashed so changes are easily reviewed) fixes this....SITL tested for flaps
e252174
to
0aef49f
Compare
autotest:add test for autoland mode
@Hwurzburg Peter and I tested yesterday, looked pretty good! |
@tridge read my comment above yours |
Captures ground course when gnd speed reaches 5m/s as takeoff direction in NAV_TAKEOFF and Mode Takeoff (if a reliable way to obtain a takeoff direction in other modes is determined, this can be expanded in the future)
Currently valid only for fixed wing configuration, quadplane wont enter mode...
Upon entry creates a final approach waypoint at parameterized distance and alt from home in the opposite direction of autotakeoff direction, flies to it and does a land exactly like NAV_LAND using full landing code for aborts. (Emulates my UniversalAutoLand LUA script #28591)
If a DO_LAND_START sequence(s) exist, will jump to them insteadIf takeoff direction has not been captured then it will just not enterthe mode
If not flying it will not enter the mode
Adds it as a long failsafe action (will RTL if no takeoff direction has been captured)...qplane ignores it
Includes an autotest