-
Notifications
You must be signed in to change notification settings - Fork 17.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AP_HAL_ChibiOS: add new target Stellar f4 #28925
Conversation
see my comments on your other board PR....they apply here also...in addition this needs the bootloader binary in Tools/bootloaders |
Done |
define HAL_FRAME_TYPE_DEFAULT 12 | ||
|
||
# filesystem setup on sdcard | ||
# define HAL_OS_FATFS_IO 1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does it have an sdcard? I don't see one defined.
|
||
# PWM out pins. Note that channel order follows the ArduPilot motor | ||
# order conventions | ||
PB6 TIM4_CH1 TIM4 PWM(1) GPIO(50) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ideally you want to enable bi-dir on the first four channels but that might require some jiggling of DMA allocations
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some comments unaddressed
6448dcb
to
308f48c
Compare
|
||
# PWM out pins. Note that channel order follows the ArduPilot motor | ||
# order conventions | ||
PB6 TIM4_CH1 TIM4 PWM(1) BIDIR GPIO(50) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
BIDIR should go on the end. Only having it for 2 motors is less than ideal
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Commit messages need splitting as per your other PR
308f48c
to
106e131
Compare
Hi! I'm a developer at StingBee, I saw the reserved board_id StellarF4 #27615
Could you please Stellar F4 support for our users of the awesome Ardupilot firmware
Thanks!