Skip to content

Use External Library BusIO #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 30 commits into from
Nov 5, 2020
Merged

Use External Library BusIO #2

merged 30 commits into from
Nov 5, 2020

Conversation

cherbel
Copy link

@cherbel cherbel commented Nov 2, 2020

NOTE: Will not work without modification to Adafruit BusIO

jgfoster
jgfoster requested changes Nov 5, 2020
View reviewed changes
Copy link
Member

@jgfoster jgfoster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comments. One value of waiting a few days to review this is that I've forgotten the things I understood a few days ago. This is a good heuristic for where more comments are needed!

jgfoster
jgfoster approved these changes Nov 5, 2020
View reviewed changes
Copy link
Member

@jgfoster jgfoster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jgfoster jgfoster merged commit 5bf6689 into Arduino-CI:arduino_ci Nov 5, 2020
@cherbel cherbel mentioned this pull request Nov 6, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jgfoster jgfoster jgfoster approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cherbel @jgfoster