Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Properly handle libraries with spaces in names, when installed as custom libraries #222

Closed
ianfixes opened this issue Nov 20, 2020 · 0 comments · Fixed by #218
Closed

Properly handle libraries with spaces in names, when installed as custom libraries #222

ianfixes opened this issue Nov 20, 2020 · 0 comments · Fixed by #218
Labels
bug Something isn't working ci scripts The test runner scripts
Milestone
OpenAcidification...

Comments

@ianfixes
Copy link
Collaborator

If a library with a space in the name is requested, we expect it to be stored on disk as having an underscore substituted for the space. Detection of already-installed libraries breaks somewhat in this case. Consider the following:

unittest:
  platforms:
    - mega2560
  libraries:
    - "Adafruit BusIO"
    # - "Adafruit_BusIO"    <= This works if you have the library pre-installed
@ianfixes ianfixes added bug Something isn't working ci scripts The test runner scripts labels Nov 20, 2020
@ianfixes ianfixes added this to the OpenAcidification Support milestone Nov 20, 2020
This was referenced Nov 20, 2020
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working ci scripts The test runner scripts
Projects
None yet
Milestone
OpenAcidification Support
Development

Successfully merging a pull request may close this issue.

Use arduino-cli backend ianfixes/arduino_ci
1 participant
@ianfixes