Skip to content

Update docs to explain purpose of SampleProjects #156

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 6, 2020

Conversation

jgfoster
Copy link
Member

@jgfoster jgfoster commented Sep 8, 2020

This should avoid the impression that they are templates to be followed too closely. This is a partial fix for #149.

James Foster added 2 commits September 8, 2020 10:19
… that they are templates to be followed too closely.
…n't work on macOS 10.16).

- Correct location for your project.
@ianfixes
Copy link
Collaborator

ianfixes commented Sep 8, 2020

I started writing some inline comments, but I think it's more valuable to just have you rewrite docs as you see fit because that gives me an idea of what's unclear (and in what sense it's unclear). I will probably end up using whatever changes you add to this PR as a guide for beefing up these docs, and I'll have you take a look at my edits (in a separate PR) to see if they address what you're finding here.

TL;DR, I don't get many opportunities to see this code through the eyes of a new user so please don't hold back -- I'll worry about smoothing it out at a later point

@ianfixes ianfixes added docs Documentation enhancement New feature or request labels Sep 8, 2020
@jgfoster
Copy link
Member Author

jgfoster commented Sep 8, 2020

That's fine. I'm happy to provide feedback in whatever manner seems easier for you. I appreciate the quick turn-around on the ideas and questions. I'm learning a lot, making good progress, and will have more submissions for your consideration soon.

@jgfoster
Copy link
Member Author

jgfoster commented Oct 6, 2020

An unrelated matter (new issue?) but related to seeing things from the eyes of a new user:

I struggled with the compile vs. unit test options for a while. I spent a lot of time struggling with the compiler to get the unit tests to work and the idea that I'm running the unit tests without compiling (them?) seems very odd. Now that I'm understanding better I wonder if "Compile Examples" would be a better phrase (even though it is more verbose).

@ianfixes ianfixes merged commit 6eee41a into Arduino-CI:master Oct 6, 2020
@ianfixes
Copy link
Collaborator

ianfixes commented Oct 6, 2020

Lets's absolutely open that new issue. SampleProjects becomes CompileExamples? I really like that idea.

@jgfoster jgfoster deleted the docs branch October 14, 2020 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants