Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test for #192: fatal error: 'Adafruit_SPIDevice.h' file not found #212

Closed
wants to merge 4 commits into from

Conversation

jgfoster
Copy link
Member

This should make it easier to debug #192.

@ianfixes
Copy link
Collaborator

The motivation behind this PR seems to be illustrating the problem fixed by #213 but this doesn't quite close the loop... this project doesn't get included in the CI config.

I'm wondering if https://github.com/Arduino-CI/arduino_ci/tree/master/SampleProjects/DependOnSomething could be adapted to perform this test.

@jgfoster
Copy link
Member Author

jgfoster commented Nov 15, 2020

This is illustrating the problem reported in #192 (not #213) which is not yet fixed. It wasn't added to CI because it would cause the CI to fail. Once #192 is fixed then we can include it into the CI. Testing it elsewhere would be fine; I just wanted to give you a simple failing test.

@jgfoster
Copy link
Member Author

Replace with PR to tdd branch.

@ianfixes
Copy link
Collaborator

Rolled into #223 and merged

@ianfixes
Copy link
Collaborator

I got an email that

I find that #212 still fails so this doesn't seem to be fixed.

I don't see that comment here so I assume it was retracted. Please open a new issue if the problem comes back, as #218 will have affected quite a few things

@jgfoster
Copy link
Member Author

Yes, I discovered that the problem was elsewhere.

@jgfoster jgfoster deleted the BusIO branch April 15, 2021 23:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants