Skip to content

Create a more complete CI environment in a Docker image #238

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 16 commits into from
Dec 28, 2020
Merged

Create a more complete CI environment in a Docker image #238

merged 16 commits into from
Dec 28, 2020

Conversation

ianfixes
Copy link
Collaborator

@ianfixes ianfixes commented Dec 9, 2020 •
edited
Loading

Highlights from CHANGELOG.md

Working towards a solution where configuration of environment variables is all that controls a Docker image that can be used for testing

Added

  • Environment variable to run a custom initiialization script during CI testing: CUSTOM_INIT_SCRIPT
  • Environment variable to run from a subdirectory during CI testing: USE_SUBDIR

Changed

  • Rubocop expected syntax downgraded from ruby 2.6 to 2.5

Fixed

  • Warnings about directory name mismatches are now based on proper comparison of strings
  • See CHANGELOG.md for more

Issues Fixed

@ianfixes ianfixes changed the title 2020 12 08 toward containers Environment variables to create a more complete CI environment in a Docker iamge Dec 9, 2020
@ianfixes ianfixes changed the title Environment variables to create a more complete CI environment in a Docker iamge Environment variables to create a more complete CI environment in a Docker image Dec 9, 2020
@ianfixes ianfixes force-pushed the 2020-12-08_toward_containers branch 2 times, most recently from c7f6630 to 4d41338 Compare December 10, 2020 16:14
@ianfixes ianfixes added this to the 2020 Wrapup milestone Dec 23, 2020
@ianfixes ianfixes mentioned this pull request Dec 24, 2020
Merged
@ianfixes ianfixes force-pushed the 2020-12-08_toward_containers branch from 9d52d4e to 5a1a42a Compare December 26, 2020 05:27
@ianfixes ianfixes mentioned this pull request Dec 26, 2020
Closed
@ianfixes ianfixes force-pushed the 2020-12-08_toward_containers branch from 5a1a42a to ac386b4 Compare December 26, 2020 05:38
jgfoster
jgfoster reviewed Dec 27, 2020
View reviewed changes
Copy link
Member

@jgfoster jgfoster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, I like it. At first I was confused by the changes in testing macro names being part of the Docker PR, but I think I follow what is happening now.

@ianfixes ianfixes force-pushed the 2020-12-08_toward_containers branch from ac386b4 to ee7d911 Compare December 28, 2020 04:12
@ianfixes ianfixes changed the title Environment variables to create a more complete CI environment in a Docker image Create a more complete CI environment in a Docker image Dec 28, 2020
@ianfixes ianfixes force-pushed the 2020-12-08_toward_containers branch from ee7d911 to 0fb612a Compare December 28, 2020 04:59
@ianfixes ianfixes force-pushed the 2020-12-08_toward_containers branch from 0fb612a to 6a16d27 Compare December 28, 2020 15:36
@ianfixes ianfixes merged commit e592ea7 into Arduino-CI:master Dec 28, 2020
ianfixes added a commit to ianfixes/arduino_ci that referenced this pull request Dec 28, 2020
@ianfixes
Merge pull request Arduino-CI#238 from ianfixes/2020-12-08_toward_con…
757cfb2 
…tainers

Create a more complete CI environment in a Docker image
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jgfoster jgfoster jgfoster left review comments

+1 more reviewer

@per1234 per1234 per1234 left review comments

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2020 Wrapup
3 participants
@ianfixes @jgfoster @per1234